[FLINK-21340] CheckForbiddenMethodsUsage is not run and fails

• Type: Technical Debt
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.17.0
• Component/s: Tests
• Labels: auto-deprioritized-major pull-request-available
• Assignee: Chesnay Schepler
• Reporter: Chesnay Schepler
• Created: 09/Feb/21 15:18
• Updated: 21/Nov/22 11:16
• Resolved: 21/Nov/22 11:16

Description

This seems to be intended as a manual test, that checks that certain methods are not being used.

It currently fails for 35 instances, 26 of which are for classes from flink-shaded (i.e., out of our control).

We should either adjust the test it ignore flink-shaded and fix the remaining issues, or remove the test.

flink-shaded classes could be ignored pretty easily like this:

            methodUsages.removeIf(
                    memberUsage ->
                            memberUsage
                                    .getDeclaringClass()
                                    .getPackageName()
                                    .startsWith("org.apache.flink.shaded"));

These are the remaining failures:

private static void org.apache.flink.api.common.typeutils.TypeSerializerSerializationUtilTest.modifySerialVersionUID(byte[],java.lang.String,long) throws java.lang.Exception
public void org.apache.flink.util.IOUtilsTest.testTryReadFullyFromLongerStream() throws java.io.IOException
public void org.apache.flink.core.io.PostVersionedIOReadableWritableTest.testReadNonVersionedWithLongPayload() throws java.io.IOException
public void org.apache.flink.streaming.api.operators.AbstractStreamOperatorTest.testCustomRawKeyedStateSnapshotAndRestore() throws java.lang.Exception
public void org.apache.flink.util.IOUtilsTest.testTryReadFullyFromShorterStream() throws java.io.IOException
public void org.apache.flink.core.io.PostVersionedIOReadableWritableTest.testReadVersioned() throws java.io.IOException
private org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter$ChannelStateWriteResult org.apache.flink.runtime.state.ChannelPersistenceITCase.write(long,java.util.Map,java.util.Map) throws java.lang.Exception
public void org.apache.flink.core.memory.HybridOnHeapMemorySegmentTest.testReadOnlyByteBufferPut()
private static org.apache.flink.runtime.state.IncrementalRemoteKeyedStateHandle org.apache.flink.runtime.state.IncrementalRemoteKeyedStateHandleTest.create(java.util.Random)

Issue Links

• is related to: FLINK-21338 Relax test naming constraints
• links to: GitHub Pull Request #21312