[FLINK-20915] Move docker-entrypoint.sh logic into distribution

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Component/s: Deployment / Scripts
• Labels: pull-request-available
• Assignee: Chesnay Schepler
• Reporter: Chesnay Schepler
• Created: 11/Jan/21 00:19
• Updated: 28/Jan/21 09:32
• Resolved: 20/Jan/21 21:02

Description

Copy most of the existing docker-entrypoint.sh into the distribution and defer to it from the docker image. This will make it easier for us to align the distribution and docker entrypoints, hopefully preventing disasters like the 1.12 release.
The only things remaining in the image are things that are intrinsically tied to the image, like the jmalloc switch.

Over time we should look into reducing the amount of docker-specific logic in this script.
For example,

• setting various config options at startup could be moved into the image creation by modifying flink-conf.yaml right away (in a way, creating a custom docker distribution)
• docker-specific environment variables (for plugins the the number of slots for task executors) could be supported in all modes

Issue Links

• is related to: FLINK-21034 Rework jemalloc switch to use an environment variable
• is related to: FLINK-21035 Deduplicate copy_plugins_if_required calls
• is related to: FLINK-21037 Deduplicate configuration logic in docker entrypoint
• links to: GitHub Pull Request #54
• links to: GitHub Pull Request #14630