[FLINK-20805] Blink runtime classes partially ignored by spotless

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.11.4, 1.12.1, 1.13.0
• Fix Version/s: 1.11.4, 1.12.1, 1.13.0
• Component/s: Build System
• Labels: pull-request-available
• Assignee: Chesnay Schepler
• Reporter: Chesnay Schepler
• Created: 29/Dec/20 14:39
• Updated: 28/May/21 06:59
• Resolved: 30/Dec/20 15:52

Description

The spotless configuration has an exclude for classes whose package contains "generated", to filter out generated classes.
However the only classes matching this exclusion are several files in flink-table-runtime-blink, which do not appear to be generated.

I suggest to remove the exclusion and apply the formatting to these classes as well.

Issue Links

• causes: FLINK-20841 Fix compile error due to duplicated generated files
• is caused by: FLINK-20820 Rename o.a.f.table.runtime.generated package in blink runtime
• is related to: FLINK-20651 Use Spotless/google-java-format for code formatting/enforcement
• links to: GitHub Pull Request #14520