[FLINK-20792] Allow shorthand invocation of spotless

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.11.4, 1.12.1, 1.13.0
• Fix Version/s: 1.11.4, 1.12.1, 1.13.0
• Component/s: Build System
• Labels: pull-request-available
• Assignee: Chesnay Schepler
• Reporter: Chesnay Schepler
• Created: 28/Dec/20 18:55
• Updated: 28/May/21 06:58
• Resolved: 29/Dec/20 10:31

Description

It is currently not possible to just run mvn spotless:check, but instead one needs to use the fully qualified name of the plugin, i.e., mvn com.diffplug.spotless:spotless-maven-plugin:check.

This is due to force-shading; this module is declared as a child of the flink-parent pom (i.e., the root pom of the project), but is not actually declaring that very module as it's parent.
This seems to throw of maven, which fails to retrieve the plugin information from the parent.

(Essentially, flink-parent tells maven "run this plugin for each of my children", maven asks child "so what should we actually do", child says "duh ask my parent", but that parent is just some random dude that doesn't know anything and maven doesn't know what to do.)

Issue Links

• is caused by: FLINK-20802 force-shading does not declare flink-parent as it's parent
• is related to: FLINK-20651 Use Spotless/google-java-format for code formatting/enforcement
• links to: GitHub Pull Request #14511