[FLINK-19927] ExecutionStateUpdateListener is only updated when legacy scheduling is enabled

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.12.0
• Fix Version/s: 1.12.0
• Component/s: Runtime / Coordination
• Labels: pull-request-available
• Assignee: Andrey Zagrebin
• Reporter: Robert Metzger
• Created: 02/Nov/20 10:40
• Updated: 04/Nov/20 08:02
• Resolved: 04/Nov/20 08:02

Description

This is a finding from FLINK-19805.

The ExecutionDeploymentTracker is never notified about executions reaching terminal state, when using the default scheduler.
This can potentially lead to invalid execution reconciliation behavior.

Fixing this ticket probably involves switching the statements here: https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java#L1688-L1692

As part of the this tickets resolution, I suggest to also introduce a test case.

Issue Links

• causes: FLINK-19805 LeaderChangeClusterComponentsTest.testReelectionOfJobMaster is instable
• is related to: FLINK-19954 Move execution deployment tracking logic from legacy EG code to SchedulerNG
• links to: GitHub Pull Request #13908