[FLINK-19894] Use iloc for positional slicing instead of direct slicing in from_pandas

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.11.0, 1.12.0
• Fix Version/s: 1.11.3, 1.12.0
• Component/s: API / Python
• Labels: pull-request-available
• Assignee: Huang Xingbo
• Reporter: Huang Xingbo
• Created: 30/Oct/20 07:55
• Updated: 02/Nov/20 02:36
• Resolved: 02/Nov/20 02:35

Description

When you use floats are index of pandas, it produces a wrong results:

 

>>> import pandas as pd
>>> t_env.from_pandas(pd.DataFrame({'a': [1, 2, 3]}, index=[2., 3., 4.])).to_pandas()
   a
0  1
1  2

 

This is because direct slicing uses the value as index when the index contains floats:

 

>>> pd.DataFrame({'a': [1,2,3]}, index=[2., 3., 4.])[2:]
     a
2.0  1
3.0  2
4.0  3
>>> pd.DataFrame({'a': [1,2,3]}, index=[2., 3., 4.]).iloc[2:]
     a
4.0  3
>>> pd.DataFrame({'a': [1,2,3]}, index=[2, 3, 4])[2:]
   a
4  3

 

Issue Links

• links to: GitHub Pull Request #13855