[FLINK-19456] sql client execute insert sql with comment ahead

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.11.2
• Component/s: Table SQL / Client
• Labels: stale-major

Environment

flink-1.11.2-bin-scala_2.11

standalone cluster

bin/sql-client.sh embedded

• Assignee: Unassigned
• Reporter: ledong Lin
• Created: 29/Sep/20 14:48
• Updated: 29/Apr/21 08:16
• Resolved: 29/Apr/21 08:16

Description

Environment: standalone cluster
Step in sql client:

Flink SQL> create table a( a string) with ( 'connector'='print');
 [INFO] Table has been created.
Flink SQL> –- test
 > insert into a
 > select date_format(current_timestamp, 'yyyyMMdd');
 [INFO] Submitting SQL update statement to the cluster...
Exception in thread "main" org.apache.flink.table.client.SqlClientException: Unexpected exception. This is a bug. Please consider filing an issue.Exception in thread "main" org.apache.flink.table.client.SqlClientException: Unexpected exception. This is a bug. Please consider filing an issue. at org.apache.flink.table.client.SqlClient.main(SqlClient.java:213)Caused by: java.lang.NullPointerException at org.apache.flink.table.client.cli.CliClient.callInsert(CliClient.java:598) at org.apache.flink.table.client.cli.CliClient.callCommand(CliClient.java:315) at java.util.Optional.ifPresent(Optional.java:159) at org.apache.flink.table.client.cli.CliClient.open(CliClient.java:212) at org.apache.flink.table.client.SqlClient.openCli(SqlClient.java:142) at org.apache.flink.table.client.SqlClient.start(SqlClient.java:114) at org.apache.flink.table.client.SqlClient.main(SqlClient.java:201)
Shutting down the session...done.

And the `-- test` is the cause of the problem. 

error info in flink-llin-sql-client-bigdata00.log

2020-09-29 22:10:54,325 ERROR org.apache.flink.table.client.SqlClient                      [] - SQL Client must stop. Unexpected exception. This is a bug. Please consider filing an issue.java.lang.NullPointerException: null
    at org.apache.flink.table.client.cli.CliClient.callInsert(CliClient.java:598) ~[flink-sql-client_2.11-1.11.2.jar:1.11.2]
    at org.apache.flink.table.client.cli.CliClient.callCommand(CliClient.java:315) ~[flink-sql-client_2.11-1.11.2.jar:1.11.2]
    at java.util.Optional.ifPresent(Optional.java:159) ~[?:1.8.0_202]    at org.apache.flink.table.client.cli.CliClient.open(CliClient.java:212) ~[flink-sql-client_2.11-1.11.2.jar:1.11.2]
    at org.apache.flink.table.client.SqlClient.openCli(SqlClient.java:142) ~[flink-sql-client_2.11-1.11.2.jar:1.11.2]
    at org.apache.flink.table.client.SqlClient.start(SqlClient.java:114) ~[flink-sql-client_2.11-1.11.2.jar:1.11.2]
    at org.apache.flink.table.client.SqlClient.main(SqlClient.java:201) [flink-sql-client_2.11-1.11.2.jar:1.11.2]