Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-19362

Remove confusing comment for `DOT` operator codegen

    XMLWordPrintableJSON

Details

    Description

      `DOT` operator codegen (ExprCodeGenerator#generateCallExpression) has comment as following:

      // due to https://issues.apache.org/jira/browse/CALCITE-2162, expression such as
      // "array[1].a.b" won't work now.
      if (operands.size > 2) {
        throw new CodeGenException(
          "A DOT operator with more than 2 operands is not supported yet.")
      }
      

      But `array[1].a.b` actually can work for flink job. `DOT` will be transform to `RexFieldAccess` for CALCITE-2542. And `generateDot` will never be invoked  except suppporting ITEM for ROW types.

      Simply, I think we can only delete the comment which is confusing. 

      Attachments

        Activity

          People

            Unassigned Unassigned
            hailong wang hailong wang
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated: