[FLINK-18355] Simplify tests of SlotPoolImpl

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.12.0
• Component/s: Runtime / Coordination, Tests
• Labels: pull-request-available
• Assignee: Zhilong Hong
• Reporter: Zhu Zhu
• Created: 18/Jun/20 03:46
• Updated: 13/Aug/20 01:10
• Resolved: 13/Aug/20 01:10

Description

Tests of SlotPoolImpl, including SlotPoolImplTest, SlotPoolInteractionsTest and SlotPoolSlotSharingTest, are somehow unnecessarily complicated in the code involvement. E.g. SchedulerImp built on top of SlotPoolImpl is used to allocate slots from SlotPoolImpl, which can be simplified by directly invoke slot allocation on SlotPoolImpl.
Besides that, there are quite some duplications between tests classes of SlotPoolImpl, this further includes SlotPoolPendingRequestFailureTest, SlotPoolRequestCompletionTest and SlotPoolBatchSlotRequestTest.

It can ease future development and maintenance a lot if we clean up these tests by
1. introduce a comment test base for fields and methods reuse
2. remove the usages of SchedulerImp for slotpool testing
3. other possible simplifications

Issue Links

• links to: GitHub Pull Request #12917