[FLINK-18257] MasterStateSnapshot future may not be completed

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Not A Bug
• Affects Version/s: 1.11.0
• Fix Version/s: 1.11.0
• Component/s: Runtime / Checkpointing
• Assignee: Roman Khachatryan
• Reporter: Roman Khachatryan
• Created: 11/Jun/20 11:18
• Updated: 11/Jun/20 15:06
• Resolved: 11/Jun/20 15:06

Description

From https://issues.apache.org/jira/browse/FLINK-18137?focusedCommentId=17133144&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17133144:

There are several cases when masterStateCompletableFuture can be left incomplete:

1. checkpoint is discarded (aborted) - line 690 throws an exception instead of completing the future
2. checkpoint is discarded (aborted) - line 696 doesn't complete the future even if everything is acked (what  has trohrmann found)
3. CompletableFuture.allOf waits for both masterStates and coordinatorCheckpoints futures while it could "return" as soon as one fails

Need to check first.