[FLINK-18217] config.sh#extractExecutionResults does not fail on wrong input - ASF JIRA

Attach files

Attach Screenshot

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Closed
Priority: Blocker
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 1.11.0
Component/s: Deployment / Scripts
Labels:
- pull-request-available

Description

If the BashJavaUtils fail, and config.sh#extractExecutionResults is called with the exception output, which does not contain the expected lines, then it will not detect an error.

execution_results=$(echo "${output}" | grep ${EXECUTION_PREFIX})
num_lines=$(echo "${execution_results}" | wc -l)
    if [[ ${num_lines} -ne ${expected_lines} ]]; then

Apparently, even if execution_results is empty, $(echo "${execution_results}" | wc -l) returns 1.