[FLINK-18038] StateBackendLoader logs application-defined state before it is fully configured

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.9.1
• Fix Version/s: 1.12.0
• Component/s: Runtime / State Backends
• Labels: pull-request-available
• Assignee: Steve Bairos
• Reporter: Steve Bairos
• Created: 29/May/20 22:32
• Updated: 13/Apr/21 20:41
• Resolved: 05/Jun/20 08:40

Description

In the StateBackendLoader, there's this log line:

logger.info("Using application-defined state backend: {}", fromApplication); 

It seems like this is inaccurate though because immediately after logging this, if fromApplication is a ConfigurableStateBackend, we call the .configure() function and it is replaced by a newly configured StateBackend. 

To me, it seems like it would be better if we logged the state backend after it was fully configured. In the current setup, we get confusing logs like this: 

2020-05-29 21:39:44,387 INFO  org.apache.flink.streaming.runtime.tasks.StreamTask           - Using application-defined state backend: RocksDBStateBackend{checkpointStreamBackend=File State Backend (checkpoints: 's3://pinterest-montreal/checkpoints/xenon-dev-001-20191210/Xenon/BasicJavaStream', savepoints: 'null', asynchronous: UNDEFINED, fileStateThreshold: -1), localRocksDbDirectories=null, enableIncrementalCheckpointing=UNDEFINED, numberOfTransferingThreads=-1}2020-05-29 21:39:44,387 INFO  org.apache.flink.streaming.runtime.tasks.StreamTask           - Configuring application-defined state backend with job/cluster config

Which makes it ambiguous whether or not settings in our flink-conf.yaml like "state.backend.incremental: true" are being applied properly or not. 

 

I can make a diff for the change if there aren't any objections

Issue Links

• links to: GitHub Pull Request #12494