[FLINK-17827] scala-shell.sh should fail early if no mode is specified, or have default logging settings

• Type: Improvement
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.11.0
• Fix Version/s: 1.13.0
• Component/s: Scala Shell
• Labels: pull-request-available starter
• Assignee: Unassigned
• Reporter: Chesnay Schepler
• Created: 20/May/20 07:44
• Updated: 28/May/21 07:00
• Resolved: 04/Jan/21 12:07

Description

The scala-shell has multiple modes it can run in: local, remote and yarn.
It is mandatory to specify such a mode, but this is only enforced on the scala side, not in the bash script.

The problem is that the scala-shell script derives the log4j properties from the mode, and if no mode is set, then the log4j properties are empty.
This leads to a warning from slf4j that no logger was defined and all that.

Either scala-shell.sh should fail early if no mode is specified, or it should have some default logging settings (e.g., the ones for local/remote).

Issue Links

• links to: GitHub Pull Request #14399