Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-17532

Update tests to use BatchTestBase#checkTableResult

    XMLWordPrintableJSON

    Details

    • Type: Test
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Table SQL / Planner
    • Labels:

      Description

      Roughly 196 tests fail if we change the `Row.toString`. In the legacy planner, we will fix this quickly using some util. However, for the long-term Blink planner we should update those test to use the test bases and compare against instances instead of string.

      Similar to:

          checkResult(
            "SELECT j, sum(k) FROM GenericTypedTable3 GROUP BY i, j",
            Seq(
              row(row(1, 1), 2),
              row(row(1, 1), 2),
              row(row(10, 1), 3)
            )
          )
      

      Affected tests:

      AggregateITCaseBase
      PartitionableSinkITCase
      CalcITCase
      JoinITCase
      SortITCase
      CorrelateITCase
      TableSinkITCase
      AggregationITCase
      GroupWindowITCase
      SetOperatorsITCase
      CalcITCase
      UnnestITCase
      AggregateRemoveITCase
      PruneAggregateCallITCase
      CalcITCase
      CorrelateITCase
      TableSinkITCase
      SetOperatorsITCase
      

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              twalthr Timo Walther
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated: