[FLINK-17187] Streamline setting of config options

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: docker-1.9.3.0, docker-1.10.1.0, docker-1.11.0.0
• Component/s: flink-docker
• Labels: pull-request-available
• Assignee: Chesnay Schepler
• Reporter: Chesnay Schepler
• Created: 16/Apr/20 11:31
• Updated: 10/Aug/20 13:49
• Resolved: 24/Apr/20 07:45

Description

The docker-entrypoint.sh has some verbose sections for setting config options with lots of duplicated logic. We should introduce a utility method for setting config options.

 

if grep -E "^jobmanager\.rpc\.address:.*" "${CONF_FILE}" > /dev/null; then
    sed -i -e "s/jobmanager\.rpc\.address:.*/jobmanager.rpc.address: ${JOB_MANAGER_RPC_ADDRESS}/g" "${CONF_FILE}"
else
    echo "jobmanager.rpc.address: ${JOB_MANAGER_RPC_ADDRESS}" >> "${CONF_FILE}"
fiif grep -E "^blob\.server\.port:.*" "${CONF_FILE}" > /dev/null; then
    sed -i -e "s/blob\.server\.port:.*/blob.server.port: 6124/g" "${CONF_FILE}"
else
    echo "blob.server.port: 6124" >> "${CONF_FILE}"
fi
...

Issue Links

• links to: GitHub Pull Request #12