[FLINK-17023] Improve handling of unexpected input in config.sh#extractExecutionParams

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.11.0
• Fix Version/s: 1.11.0
• Component/s: Deployment / Scripts
• Labels: pull-request-available
• Assignee: Caizhi Weng
• Reporter: Caizhi Weng
• Created: 07/Apr/20 06:57
• Updated: 20/Apr/20 10:07
• Resolved: 17/Apr/20 15:49

Description

In FLINK-15727 BashJavaUtils now returns multiple lines of results to avoid using BashJavaUtils twice. But now the format checking in extractExecutionParams for the last line is incorrect. Instead of

if ! [[ $execution_config =~ ^${EXECUTION_PREFIX}.* ]]; then
    echo "[ERROR] Unexpected result: $execution_config" 1>&2
    echo "[ERROR] The last line of the BashJavaUtils outputs is expected to be the execution result, following the prefix '${EXECUTION_PREFIX}'" 1>&2
    echo "$output" 1>&2
    exit 1
fi

It should be

last_line=`echo "$execution_config" | tail -n 1`
if ! [[ "$last_line" =~ ^${EXECUTION_PREFIX}.* ]]; then
# ...

Issue Links

• breaks: FLINK-17264 taskmanager.sh could not work on Mac
• is caused by: FLINK-15727 Let BashJavaUtils return dynamic configs and JVM parameters in one call
• links to: GitHub Pull Request #11764