[FLINK-16836] Losing leadership does not clear rpc connection in JobManagerLeaderListener

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.11.0
• Fix Version/s: 1.9.3, 1.10.1, 1.11.0
• Component/s: Runtime / Coordination
• Labels: pull-request-available
• Assignee: Till Rohrmann
• Reporter: Till Rohrmann
• Created: 27/Mar/20 19:44
• Updated: 02/Apr/20 12:01
• Resolved: 02/Apr/20 12:01

Description

When losing the leadership the JobManagerLeaderListener closes the current rpcConnection but does not clear the field. This can lead to a failure of JobManagerLeaderListener#reconnect if this method is called after the JobMaster has lost its leadership.

I propose to clear the field so that RegisteredRpcConnection#tryReconnect won't be called on a closed rpc connection.

Issue Links

• relates to: FLINK-14316 Stuck in "Job leader ... lost leadership" error
• links to: GitHub Pull Request #11552