Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-16753

Exception from AsyncCheckpointRunnable should be wrapped in CheckpointException

    XMLWordPrintableJSON

    Details

      Description

      If an exception is thrown from task's async checkpoint process, the checkpoint will be declined as expected, but the reason for declining checkpoint will be regarded as CheckpointFailureReason.JOB_FAILURE, which gives a wrong message to users.

      I think we can simply replace

      owner.getEnvironment().declineCheckpoint(checkpointMetaData.getCheckpointId(), checkpointException);
      

      with

      owner.getEnvironment().declineCheckpoint(checkpointMetaData.getCheckpointId(), new CheckpointException(CheckpointFailureReason.EXCEPTION, checkpointException));
      

      in AsyncCheckpointRunnable.handleExecutionException.

      cc Till Rohrmann

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                wind_ljy Jiayi Liao
                Reporter:
                wind_ljy Jiayi Liao
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 10m
                  10m