Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-16619

Misleading SlotManagerImpl logging for slot reports of unknown task manager

    XMLWordPrintableJSON

    Details

      Description

      If the SlotManager receives a slot report from an unknown task manager it logs 2 messages:

      public boolean reportSlotStatus(InstanceID instanceId, SlotReport slotReport) {
      	[...]
      	LOG.debug("Received slot report from instance {}: {}.", instanceId, slotReport);
      
      	TaskManagerRegistration taskManagerRegistration = taskManagerRegistrations.get(instanceId);
      
      	if (null != taskManagerRegistration) {
      		[...]
      	} else {
      		LOG.debug("Received slot report for unknown task manager with instance id {}. Ignoring this report.", instanceId);
      		[...]
      	}
      }
      

      This leads to misleading output since it appears like the slot manager received 2 separate slot reports, with the first being for a known instance, the latter for an unknown one. This cost some time as I couldn't figure out why the "latter" report was suddenly being rejected.

      I propose moving the first debug message into the non-null branch.

      Till Rohrmann WDYT?

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                chesnay Chesnay Schepler
                Reporter:
                chesnay Chesnay Schepler
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: