[FLINK-16619] Misleading SlotManagerImpl logging for slot reports of unknown task manager

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.10.0
• Fix Version/s: 1.10.2, 1.11.2, 1.12.0
• Component/s: Runtime / Coordination
• Labels: pull-request-available
• Assignee: Chesnay Schepler
• Reporter: Chesnay Schepler
• Created: 16/Mar/20 13:56
• Updated: 03/Aug/20 20:16
• Resolved: 03/Aug/20 20:16

Description

If the SlotManager receives a slot report from an unknown task manager it logs 2 messages:

public boolean reportSlotStatus(InstanceID instanceId, SlotReport slotReport) {
	[...]
	LOG.debug("Received slot report from instance {}: {}.", instanceId, slotReport);

	TaskManagerRegistration taskManagerRegistration = taskManagerRegistrations.get(instanceId);

	if (null != taskManagerRegistration) {
		[...]
	} else {
		LOG.debug("Received slot report for unknown task manager with instance id {}. Ignoring this report.", instanceId);
		[...]
	}
}

This leads to misleading output since it appears like the slot manager received 2 separate slot reports, with the first being for a known instance, the latter for an unknown one. This cost some time as I couldn't figure out why the "latter" report was suddenly being rejected.

I propose moving the first debug message into the non-null branch.

trohrmann WDYT?

Issue Links

• links to: GitHub Pull Request #13049