Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-16443

Fix wrong fix for user-code CheckpointExceptions

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      The problem of having exceptions that are only in the user code classloader was fixed by proactively serializing them inside the CheckpointException. That means all consumers of CheckpointException now need to be aware of that and unwrap the serializable exception.

      I believe the right way to fix this would have been to use a SerializedException in the DeclineCheckpoint message instead, which would have localized the change to the actual problem: RPC transport.

      I would suggest to revert https://github.com/apache/flink/pull/9742 and instead apply the above described change.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            arvid Arvid Heise
            sewen Stephan Ewen
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment