[FLINK-15549] Integer overflow in SpillingResettableMutableObjectIterator

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6.4, 1.7.2, 1.8.3, 1.9.1, 1.10.0
• Fix Version/s: 1.8.4, 1.9.2, 1.10.0
• Component/s: API / DataSet
• Labels: overflow pull-request-available
• Assignee: caojian0613
• Reporter: caojian0613
• Created: 10/Jan/20 10:16
• Updated: 24/Jan/20 01:13
• Resolved: 21/Jan/20 09:23

Description

The SpillingResettableMutableObjectIterator has a data overflow problem if the number of elements in a single input exceeds Integer.MAX_VALUE.

The reason is inside the SpillingResettableMutableObjectIterator, it track the total number of elements and the number of elements currently read with two int type fileds (elementCount and currentElementNum), and if the number of elements exceeds Integer.MAX_VALUE, it will overflow.

If there is an overflow, then in the next iteration, after reset the input , the data will not be read or only part of the data will be read.

Therefore, we should changing the type of these two fields of SpillingResettableIterator* from int to long, and we also need a pre-check mechanism before such numerical.

Issue Links

• is duplicated by: FLINK-15581 SpillingResettableMutableObjectIterator data overflow
• links to: GitHub Pull Request #10903