Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-15523

ConfigConstants generally excluded from japicmp

    XMLWordPrintableJSON

    Details

      Description

      It appears that ConfigConstants, despite being @Public, has been excluded from the japicmp check since 1.5.0: https://github.com/apache/flink/commit/1f9c2d9740ffea2b59b8f5f3da287a0dc890ddbf

      This is a bit of a surprise to me and looks like a mistake (what's the point of excluding specific fields if the entire class is excluded), and if so this has repercussions on some ongoing work:

      Breaking the build because there is at least one incompatibility: org.apache.flink.configuration.ConfigConstants.TASK_MANAGER_MEMORY_SIZE_KEY:FIELD_REMOVED,
      org.apache.flink.configuration.ConfigConstants.TASK_MANAGER_MEMORY_OFF_HEAP_KEY:FIELD_REMOVED,
      org.apache.flink.configuration.ConfigConstants.DEFAULT_TASK_MANAGER_MEMORY_PRE_ALLOCATE:FIELD_REMOVED,
      org.apache.flink.configuration.ConfigConstants.TASK_MANAGER_MEMORY_PRE_ALLOCATE_KEY:FIELD_REMOVED,
      org.apache.flink.configuration.ConfigConstants.TASK_MANAGER_MEMORY_FRACTION_KEY:FIELD_REMOVED,
      org.apache.flink.configuration.ConfigConstants.YARN_MAX_FAILED_CONTAINERS:FIELD_REMOVED,
      org.apache.flink.configuration.ConfigConstants.DEFAULT_MEMORY_MANAGER_MEMORY_FRACTION:FIELD_REMOVED
       

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                chesnay Chesnay Schepler
                Reporter:
                chesnay Chesnay Schepler
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m