[FLINK-15386] SingleJobSubmittedJobGraphStore.putJobGraph has a logic error

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.9.0
• Fix Version/s: 1.9.3
• Component/s: Runtime / Coordination
• Labels: pull-request-available
• Assignee: Ethan Li
• Reporter: Ethan Li
• Created: 24/Dec/19 16:05
• Updated: 04/Mar/20 14:52
• Resolved: 04/Mar/20 14:52

Description

https://github.com/apache/flink/blob/release-1.9/flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/SingleJobSubmittedJobGraphStore.java#L61-L66

	@Override
	public void putJobGraph(SubmittedJobGraph jobGraph) throws Exception {
		if (!jobGraph.getJobId().equals(jobGraph.getJobId())) { //this always returns false.
			throw new FlinkException("Cannot put additional jobs into this submitted job graph store.");
		}
	}

The code is there since 1.5 but fixed in the master branch (1.10). It's also better to add unit test for this.

Issue Links

• links to: GitHub Pull Request #10734