Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-15386

SingleJobSubmittedJobGraphStore.putJobGraph has a logic error

    XMLWordPrintableJSON

    Details

      Description

      https://github.com/apache/flink/blob/release-1.9/flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/SingleJobSubmittedJobGraphStore.java#L61-L66

      	@Override
      	public void putJobGraph(SubmittedJobGraph jobGraph) throws Exception {
      		if (!jobGraph.getJobId().equals(jobGraph.getJobId())) { //this always returns false.
      			throw new FlinkException("Cannot put additional jobs into this submitted job graph store.");
      		}
      	}
      

      The code is there since 1.5 but fixed in the master branch (1.10). It's also better to add unit test for this.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                ethanli Ethan Li
                Reporter:
                ethanli Ethan Li
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m