[FLINK-15171] Performance regression in serialisation benchmarks

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.10.0
• Fix Version/s: 1.10.0
• Component/s: API / Type Serialization System, Benchmarks
• Labels: pull-request-available
• Assignee: Piotr Nowojski
• Reporter: Piotr Nowojski
• Created: 10/Dec/19 08:57
• Updated: 05/Jan/20 08:50
• Resolved: 05/Jan/20 08:50

Description

There is quite significant performance regression in serialisation benchmarks in the commit range 2ecf7ca..9320f34 (which includes FLINK-14346).

http://codespeed.dak8s.net:8000/timeline/?ben=serializerTuple&env=2
http://codespeed.dak8s.net:8000/timeline/?ben=serializerRow&env=2
http://codespeed.dak8s.net:8000/timeline/?ben=serializerPojo&env=2

it coincides with the performance improvement for heavy strings

http://codespeed.dak8s.net:8000/timeline/?ben=serializerHeavyString&env=2

it might be caused by some accidental change in the benchmarking code (changing parallelism in one benchmarks is carried on to the next one?) or in the code itself.

CC rgrebennikov AHeise

Issue Links

• is caused by: FLINK-14346 Performance issue with StringSerializer
• links to: GitHub Pull Request #10529