Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-7282 Credit-based Network Flow Control
  3. FLINK-15021

Remove the setting of netty channel watermark in NettyServer

    XMLWordPrintableJSON

Details

    Description

      The high and low watermark setting in NetterServer before was mainly used for network flow control and limiting the maximum memory overhead caused by copying data inside netty stack. In detail, when the downstream side processes slowly and exhausted the available buffers finally, it would temporarily close the auto read switch in netty stack. Then the upstream side would finally reach the high watermark of channel to become unwritable.

      But based on credit-based flow control and reusing flink network buffer inside netty stack, the watermark setting is not invalid now. So we can safely remove it to cleanup the codes.

      Attachments

        Issue Links

          Activity

            People

              zjwang Zhijiang
              zjwang Zhijiang
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m