[FLINK-14848] BaseRowSerializer.toBinaryRow wrongly process null for non-compact decimal

• Type: Bug
• Status: Open
• Priority: Not a Priority
• Resolution: Unresolved
• Affects Version/s: 1.9.1
• Component/s: Table SQL / Runtime
• Labels: auto-deprioritized-major auto-deprioritized-minor pull-request-available
• Assignee: Unassigned
• Reporter: Zhenghua Gao
• Created: 19/Nov/19 06:33
• Updated: 18/Apr/22 10:39

Description

Take non-compact decimal(precision > 18 null as an example, the writer not only need to set null bits, but also need to assign bytes of variable-length part for future update. The following test case can reproduce the problem.

 

 

@Test
public void test() {
   Decimal dec = Decimal.fromBigDecimal(new BigDecimal(11), 38, 0);

   BinaryRow row1 = new BinaryRow(2);
   BinaryRowWriter writer = new BinaryRowWriter(row1);
   writer.writeDecimal(0, dec, 38);
   writer.writeDecimal(1, null, 38);
   writer.complete();

   BaseRowSerializer serializer = new BaseRowSerializer(null, RowType.of(new DecimalType(38, 0), new DecimalType(38, 0)));
   GenericRow row2 = new GenericRow(2);
   row2.setField(0, dec);
   row2.setField(1, null);
   BinaryRow row3 = serializer.toBinaryRow(row2);

   assertTrue(row1.equalsWithoutHeader(row3));
}

 

 

Issue Links

• links to: GitHub Pull Request #12924