[FLINK-14654] Multiple logging statements use incorrect placeholders

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.9.1
• Fix Version/s: 1.10.0
• Labels: pull-request-available
• Assignee: Yun Tang
• Reporter: Yun Tang
• Created: 07/Nov/19 10:46
• Updated: 04/Dec/19 12:31
• Resolved: 04/Dec/19 12:30

Description

As official Flink java code style suggested, we should use correct log statement format. However, there existed 13 files within current master branch that the arguments number mismatch with placeholders in log statements.

The error looks like:

LOG.warn("Failed to read native metric %s from RocksDB", property, e);

and the correct format should be

LOG.warn("Failed to read native metric {} from RocksDB.", property, e);

The other errors look like

LOG.warn("Could not find method implementations in the shaded jar. Exception: {}", e);

and the correct format should be

LOG.warn("Could not find method implementations in the shaded jar.", e);

Below is the full list of files have problems in log statements.

flink-contrib/flink-connector-wikiedits/src/main/java/org/apache/flink/streaming/connectors/wikiedits/WikipediaEditEventIrcStream.java
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/PipelineErrorHandler.java
flink-runtime/src/main/java/org/apache/flink/runtime/security/modules/HadoopModule.java
flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java
flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/ParquetPojoInputFormat.java
flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/ParquetTableSource.java
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/functions/SqlFunctionUtils.java
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/values/ValuesInputFormat.java
flink-end-to-end-tests/flink-connector-gcp-pubsub-emulator-tests/src/test/java/org/apache/flink/streaming/connectors/gcp/pubsub/emulator/GCloudEmulatorManager.java
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/ReporterSetup.java
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBNativeMetricMonitor.java

Issue Links

• links to: GitHub Pull Request #10127