[FLINK-14646] Check non-null for key in KeyGroupStreamPartitioner

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.8.2, 1.9.1, 1.10.0
• Fix Version/s: 1.8.3, 1.9.2, 1.10.0
• Component/s: Runtime / State Backends
• Labels: pull-request-available
• Assignee: Jiayi Liao
• Reporter: Jiayi Liao
• Created: 07/Nov/19 05:06
• Updated: 29/Nov/19 15:13
• Resolved: 08/Nov/19 10:00

Description

We should check non-null for key in selectChannel function in KeyGroupStreamPartitioner because KeyGroupRangeAssignment does not allow null key for assignment. And if we produce a null key in KeyGroupStreamPartitioner, the exception is not clear enough.

Caused by: java.lang.NullPointerException
	at org.apache.flink.runtime.state.KeyGroupRangeAssignment.assignToKeyGroup(KeyGroupRangeAssignment.java:60)
	at org.apache.flink.runtime.state.KeyGroupRangeAssignment.assignKeyToParallelOperator(KeyGroupRangeAssignment.java:49)
	at org.apache.flink.streaming.runtime.partitioner.KeyGroupStreamPartitioner.selectChannel(KeyGroupStreamPartitioner.java:58)
	at org.apache.flink.streaming.runtime.partitioner.KeyGroupStreamPartitioner.selectChannel(KeyGroupStreamPartitioner.java:32)
	at org.apache.flink.runtime.io.network.api.writer.RecordWriter.emit(RecordWriter.java:120)
	at org.apache.flink.streaming.runtime.io.RecordWriterOutput.pushToRecordWriter(RecordWriterOutput.java:110)
	... 9 more

Issue Links

• links to: GitHub Pull Request #10120