[FLINK-14145] getLatestCheckpoint(true) returns wrong checkpoint

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.9.0
• Fix Version/s: 1.9.1, 1.10.0
• Component/s: Runtime / Checkpointing
• Labels: pull-request-available
• Assignee: Gyula Fora
• Reporter: Ufuk Celebi
• Created: 20/Sep/19 08:06
• Updated: 29/Sep/19 03:17
• Resolved: 24/Sep/19 09:07

Description

The flag to prefer checkpoints for recovery introduced in FLINK-11159 returns the wrong checkpoint if:

• checkpoints are preferred (getLatestCheckpoint(true)),
• the latest checkpoint is not a savepoint,
• more than a single checkpoint is retained.

The current implementation assumes that the latest checkpoint is a savepoint and skips over it. I attached a patch for StandaloneCompletedCheckpointStoreTest that demonstrates the issue.

You can apply the patch via git am -3 < *.patch.

 

Issue Links

• is caused by: FLINK-11159 Allow configuration whether to fall back to savepoints for restore
• links to: GitHub Pull Request #9727
• links to: GitHub Pull Request #9756