Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-13692

Make CompletedCheckpointStore backwards compatible?

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      With FLINK-11159 we changed the signature of CompletedCheckpointStore#getLatestCheckpoint from getLatestCheckpoint() to getLatestCheckpoint(boolean). This is an API breaking change which causes users of this interface having to adapt their implementation and recompile it. Since CompletedCheckpointStore is no public API, this change is technically ok, but not so nice.

      If we decide to provide backwards compatibility, then we should still keep getLatestCheckpoint() and add a deprecation annotation to it. At least, we should update the JavaDocs of the CompletedCheckpointStore#getLatestCheckpoint method to reflect what the passed parameter states.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            trohrmann Till Rohrmann
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment