[FLINK-13604] All kinds of problem when conversion from Logical type to DataType

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: 1.9.0
• Component/s: Table SQL / API
• Labels: auto-deprioritized-critical
• Assignee: Unassigned
• Reporter: Danny Chen
• Created: 07/Aug/19 03:17
• Updated: 30/Apr/21 05:52
• Resolved: 30/Apr/21 05:52

Description

For Blink Planner:

1. Time(3) is converted to Time, the precision is lost
2. ROW<`f0` INT NOT NULL, `f1` BOOLEAN> is converted to ROW<`f0` INT, `f1` BOOLEAN>, the nullable attr is lost

the conversion code is:

LogicalTypeDataTypeConverter.fromLogicalTypeToDataType(FlinkTypeFactory.toLogicalType(relType));

For Flink planner:

1. All the Char type is converted to String type, which is totally wrong.
2. All the decimal type is converted to Legacy(BigDecimal) which is confusing ..

The conversion code is:

TypeConversions.fromLegacyInfoToDataType(FlinkTypeFactory.toTypeInfo(relType))

Please see the tests SqlToOperationConverterTest#testCreateTableWithFullDataTypes.