[FLINK-13586] Method ClosureCleaner.clean broke backward compatibility between 1.8.0 and 1.8.1

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.8.1, 1.9.0, 1.10.0
• Fix Version/s: 1.8.2
• Component/s: API / DataStream
• Labels: pull-request-available
• Assignee: Aljoscha Krettek
• Reporter: Gaël Renoux
• Created: 05/Aug/19 14:29
• Updated: 02/Oct/19 17:42
• Resolved: 04/Sep/19 10:01

Description

Method clean in org.apache.flink.api.java.ClosureCleaner received a new parameter in Flink 1.8.1. This class is noted as internal, but is used in the Kafka connectors (in org.apache.flink.streaming.connectors.kafka.FlinkKafkaProducerBase).

The Kafka connectors library is not provided by the server, and must be set up as a dependency with compile scope (see https://ci.apache.org/projects/flink/flink-docs-stable/dev/connectors/kafka.html#usage, or the Maven project template). Any project using those connectors and built with 1.8.0 cannot be deployed on a 1.8.1 Flink server, because it would target the old method.

=> This methods needs a fallback with the original two arguments (setting a default value of RECURSIVE for the level argument).

Issue Links

• is caused by: FLINK-12297 Make ClosureCleaner recursive
• relates to: FLINK-13696 Revisit & update Flink's public API annotations
• links to: GitHub Pull Request #9595