[FLINK-12646] Use reserved IP as unrouteable IP in RestClientTest

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.7.3, 1.8.1, 1.9.0
• Component/s: Runtime / REST
• Labels: pull-request-available
• Assignee: Victor Wong
• Reporter: Victor Wong
• Due: 28/May/19
• Created: 28/May/19 09:45
• Updated: 12/Jun/19 07:48
• Resolved: 11/Jun/19 13:00

Description

In

org.apache.flink.runtime.rest.RestClientTest#testConnectionTimeout

, we use a "unroutableIp" with a value of  "10.255.255.1" for test.

But sometimes this IP is reachable in a private network of a company, which is the case for me. As a result, this test failed with a following exception: 

 

java.lang.AssertionError: Expected: an instance of org.apache.flink.shaded.netty4.io.netty.channel.ConnectTimeoutException but: <org.apache.flink.shaded.netty4.io.netty.channel.AbstractChannel$AnnotatedConnectException: Connection refused: /10.255.255.1:80> is a org.apache.flink.shaded.netty4.io.netty.channel.AbstractChannel$AnnotatedConnectException at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.junit.Assert.assertThat(Assert.java:956) at org.junit.Assert.assertThat(Assert.java:923) at org.apache.flink.runtime.rest.RestClientTest.testConnectionTimeout(RestClientTest.java:76) ...

 

 

Can we change the `unroutableIp` to a reserved IP address, i.e "240.0.0.0", which is described as  Reserved for future use in wikipedia 

Or change the assertion? 

Issue Links

• links to: GitHub Pull Request #8663