[FLINK-12571] Make NetworkEnvironment#start() return the binded data port

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.9.0
• Component/s: Runtime / Network
• Labels: pull-request-available
• Assignee: Zhijiang
• Reporter: Zhijiang
• Created: 21/May/19 09:00
• Updated: 31/May/19 13:14
• Resolved: 31/May/19 13:13

Description

Currently `NetworkEnvironment#getConnectionManager()` is mainly used for `TaskManagerServices` for getting binded data port from `NettyConnectionManager`. Considering the `ConnectionManager` as an internal component of `NetworkEnvironment`, it should not be exposed for outsides. For other ShuffleService implementations, it might have no `ConnectionManager` at all.

We could make `ShuffleService#start()` return the binded data port to replace the `getConnectionManager`. For the `LocalConnectionManager` or other shuffle service implementations which have no binded data port, it could return a simple default value and it would have no harm.

Issue Links

• links to: GitHub Pull Request #8496