[FLINK-11235] Elasticsearch connector leaks threads if no connection could be established

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6.3, 1.7.1, 1.8.0
• Fix Version/s: 1.6.4, 1.7.2, 1.8.0
• Component/s: Connectors / ElasticSearch
• Labels: pull-request-available
• Assignee: lamber-ken
• Reporter: lamber-ken
• Due: 04/Jan/19
• Created: 31/Dec/18 14:32
• Updated: 02/Jan/19 11:34
• Resolved: 02/Jan/19 11:34

Description

elasticsearch transport sink init steps

1, create client thread

2, try to check every host:port

3, if each host:port is unreachable, while throw RuntimeException

but, because of throw RuntimeException, the client can not close, so causing thread leak

transport client code

```

TransportClient transportClient = new PreBuiltTransportClient(settings);
for (TransportAddress transport : ElasticsearchUtils.convertInetSocketAddresses(transportAddresses))

{ transportClient.addTransportAddress(transport); }

// verify that we actually are connected to a clusterif (transportClient.connectedNodes().isEmpty()) {
throw new RuntimeException("Elasticsearch client is not connected to any Elasticsearch nodes!");
}

return transportClient;
}

```

thread leak

thread dump

 

Issue Links

• links to: GitHub Pull Request #7387