[FLINK-11173] Proctime attribute validation throws an incorrect exception message

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.6.4, 1.7.2, 1.8.0
• Component/s: Table SQL / API
• Labels: pull-request-available
• Assignee: TANG Wen-hui
• Reporter: vinoyang
• Created: 17/Dec/18 04:59
• Updated: 04/Jan/19 14:04
• Resolved: 04/Jan/19 14:04

Description

In TableSourceUtil#validateTableSource, when uses DefinedProctimeAttribute (proctime), it throws an incorrect exception message : 

 

tableSource match {
  case p: DefinedProctimeAttribute if p.getProctimeAttribute != null =>
    val proctimeAttribute = p.getProctimeAttribute
    val proctimeIdx = schema.getFieldNames.indexOf(proctimeAttribute)
    // ensure that field exists
    if (proctimeIdx < 0) {
      throw new ValidationException(s"Found a RowtimeAttributeDescriptor for field " +
        s"'$proctimeAttribute' but field '$proctimeAttribute' does not exist in table.")
    }
    // ensure that field is of type TIMESTAMP
    if (schema.getFieldTypes()(proctimeIdx) != Types.SQL_TIMESTAMP) {
      throw new ValidationException(s"Found a RowtimeAttributeDescriptor for field " +
        s"'$proctimeAttribute' but field '$proctimeAttribute' is not of type TIMESTAMP.")
    }
  case _ => // nothing to validate
}

It still contains the keyword "RowtimeAttributeDescriptor".

Issue Links

• links to: GitHub Pull Request #7374