[FLINK-11075] Remove redundant code path in CompatibilityUtil

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Component/s: API / Type Serialization System
• Labels: pull-request-available
• Assignee: Tzu-Li (Gordon) Tai
• Reporter: Tzu-Li (Gordon) Tai
• Created: 05/Dec/18 09:07
• Updated: 15/Mar/19 11:52
• Resolved: 28/Feb/19 11:52

Description

In CompatibilityUtil#resolveCompatibilityResult:

CompatibilityResult<T> initialResult = resolveCompatibilityResult(
     (TypeSerializerSnapshot<T>) precedingSerializerConfigSnapshot,
     newSerializer);

if (!initialResult.isRequiresMigration()) {
    return initialResult;
} else {
     if (precedingSerializer != null && !(precedingSerializer.getClass().equals(dummySerializerClassTag))) {         
         // if the preceding serializer exists and is not a dummy, use
         // that for converting instead of any provided convert deserializer
        return CompatibilityResult.requiresMigration((TypeSerializer<T>) precedingSerializer);
     } else {
        // requires migration (may or may not have a convert deserializer)
        return initialResult;
}

initialResult can actually be returned already, since the case where we try to provide a convert deserializer is no longer relevant. We do not need to check if a convert deserializer is provided because that will never be the case.

Issue Links

• links to: GitHub Pull Request #7243