[FLINK-10905] HadoopConfigLoader logs Credentials on DEBUG level

• Type: Improvement
• Status: Closed
• Priority: Critical
• Resolution: Invalid
• Component/s: FileSystems
• Release Note: This was invalid. Misinterpreted the logs.
• Assignee: Unassigned
• Reporter: Konstantin Knauf
• Created: 15/Nov/18 18:15
• Updated: 15/Nov/18 18:50
• Resolved: 15/Nov/18 18:50

Description

If you set S3 credentials via s3.access-key and s3.secret-key the credentials are logged on DEBUG level in HadoopConfigLoader:104.

job-cluster_1 | 2018-11-15 18:02:25,248 DEBUG org.apache.flink.fs.s3presto.shaded.org.apache.flink.runtime.fs.hdfs.HadoopConfigLoader - Adding Flink config entry for s3.secret-key as presto.s3.secret-key=minio123 to Hadoop config
job-cluster_1 | 2018-11-15 18:02:25,248 DEBUG org.apache.flink.fs.s3presto.shaded.org.apache.flink.runtime.fs.hdfs.HadoopConfigLoader - Adding Flink config entry for s3.endpoint as presto.s3.endpoint=http://172.17.0.1:9001 to Hadoop config
job-cluster_1 | 2018-11-15 18:02:25,248 DEBUG org.apache.flink.fs.s3presto.shaded.org.apache.flink.runtime.fs.hdfs.HadoopConfigLoader - Adding Flink config entry for s3.access-key as presto.s3.access-key=minio to Hadoop config

To be consistent we should hide these as in GlobalConfiguration.