[FLEX-35293] Condition that always returns true

• Type: Bug
• Status: Open
• Priority: Trivial
• Resolution: Unresolved
• Component/s: Falcon
• Assignee: Unassigned
• Reporter: JC
• Created: 18/Apr/17 19:51
• Updated: 18/Apr/17 19:51

Description

Hi

In a recent snapshot from GirHub mirror (flex-falcon), I've found a suspicious code in compiler/src/main/java/org/apache/flex/compiler/internal/config/localization/LocalizationManager.java .

133     public String getLocalizedTextString( Locale locale, String id, Map<String, Object> parameters )
134     {
135         ILocalizedText t = getLocalizedText( locale, id );
136 
137         if ((t == null) && !locale.equals(locale))
138         {
139             t = getLocalizedText(locale, id );
140         }

In Line 137, locale.equals(locale) should be locale.equals(this.locale)? If there is a contract that this.locale and locale is always same before calling getLocalizedTextString, this might not be an issue. But wanted to report just in case. Thanks!