[FLEX-34983] Variables get annotated incorrectly when the class name contains "String"

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Apache FlexJS 0.5.0
• Fix Version/s: Apache FalconJX 0.6.0
• Component/s: Falcon, FlexJS
• Assignee: Alex Harui
• Reporter: Andy Dufilie
• Created: 11/Dec/15 04:16
• Updated: 11/Dec/15 17:57
• Resolved: 11/Dec/15 17:57

Description

If you create a class with "String" in the name, the type gets annotated incorrectly.

For example, create a class named "LinkableString" and it becomes "Linkablestring" in the annotation, causing warnings as follows:

AS Input:

var test:LinkableString = new LinkableString();

JS Output:

WARNING: C:\Weave\WeaveJS\bin\js-debug\WeaveTest.js:74: WARNING - Bad type annotation. Unknown type weavejs.core.Linkablestring
  var /** @type {weavejs.core.Linkablestring} */ test = new weavejs.core.LinkableString();

I believe the offending code is in mapBackToJS() in BaseReference.java:

https://github.com/apache/flex-falcon/blob/808fd1601a0228883b06d061d0f6bd101888284e/compiler.jx/src/org/apache/flex/compiler/internal/codegen/externals/reference/BaseReference.java#L201