Uploaded image for project: 'Apache Flex'
  1. Apache Flex
  2. FLEX-31758

few OLAP classes and interfaces have hard coded strings

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • Adobe Flex SDK Previous
    • Adobe Flex SDK Previous
    • Internationalization
    • None
    • Affected OS(s): All OS Platforms
      Affected OS(s): All OS Platforms
      Language Found: English

    Description

      Steps to reproduce:
      1. search for alert.show and throw error in olap package.

      Actual Results:
      few OLAP classes and interfaces have hard coded strings. Examples of it are...

      from IOLAPCube
      – c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/IOLAPCube.as-80- token.addResponder(new AsyncResponder(showResult, showFault));
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/IOLAPCube.as-83- // Handle a query fault.
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/IOLAPCube.as-84- private function showFault(result:Object, token:Object):void {
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/IOLAPCube.as:85: Alert.show("Error in query.")
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/IOLAPCube.as-88- // Handle a query success.
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/IOLAPCube.as-89- private function showResult(result:Object, token:Object):void {
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/IOLAPCube.as-90- if (!result)

      { c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/IOLAPCube.as:91: Alert.show("No results from query."); from CubeNodeBuilder class c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/CubeNodeBuilder.as-326- }

      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/CubeNodeBuilder.as-327- else
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/CubeNodeBuilder.as-328-

      { c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/CubeNodeBuilder.as-329- if (prevNodeAtLevel[nextLevel] && prevNodeAtLevel[nextLevel] != prevNode[value]) c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/CubeNodeBuilder.as:330: throw new Error("Assignment requried"); -- c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/CubeNodeBuilder.as-481- }

      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/CubeNodeBuilder.as-482-
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/CubeNodeBuilder.as-483- if (target.numCells == 1)
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/CubeNodeBuilder.as-484- {
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/CubeNodeBuilder.as-485- if (target.hasOwnProperty(allNodePropertyName))
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/CubeNodeBuilder.as:486: throw new Error("Some problem in logic");

      from OLAPSet

      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/OLAPSet.as-313- var t1Mems:Array = t1.explicitMembers.toArray();
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/OLAPSet.as-314- var t2Mems:Array = t2.explicitMembers.toArray();
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/OLAPSet.as-315-
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/OLAPSet.as-316- if (t1Mems.length != t2Mems.length)
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/OLAPSet.as:317: throw new Error("Member length mis match");
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/OLAPSet.as-318-
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/OLAPSet.as-319- if (t1.explicitMembers.length != t2.explicitMembers.length)
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/OLAPSet.as:320: throw new Error("Explicit Member length mis match");
      – c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/OLAPSet.as-410- {
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/OLAPSet.as-411- var tuple:OLAPTuple = tuples[index];
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/OLAPSet.as-412- var members:IList = tuple.explicitMembers;

      from QueryCubeBuilder

      – c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/QueryCubeBuilder.as-112- closingNodesBelow = prevNodeAtLevel.reverse();
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/QueryCubeBuilder.as-113- closingValues = prevValueAtLevel.reverse();
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/QueryCubeBuilder.as-114-
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/QueryCubeBuilder.as-115- if (closingValues.length != closingNodesBelow.length)
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/QueryCubeBuilder.as-116- {
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/QueryCubeBuilder.as:117: throw new QueryError("Mismatch in lenghts of closing nodes and values");
      – c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/QueryCubeBuilder.as-327- else
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/QueryCubeBuilder.as-328- {
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/QueryCubeBuilder.as-329- if (prevNodeAtLevel[nextLevel])
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/QueryCubeBuilder.as-330- {
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/QueryCubeBuilder.as-331- if (prevNodeAtLevel[nextLevel] != prevNode[value])
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/QueryCubeBuilder.as:332: throw new Error("Assignment requried");
      – c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/QueryCubeBuilder.as-548- var prop:String = "saved_" + measureName;
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/QueryCubeBuilder.as-549- var temp:Object;
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/QueryCubeBuilder.as-550- if (!node.hasOwnProperty(measureName))
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/QueryCubeBuilder.as-551- {
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/QueryCubeBuilder.as-552- if (!(node is SummaryNode))
      c:/depot/depot/flex/dmv_automation/projects/datavisualisation/src/mx/olap/QueryCubeBuilder.as:553: throw new Error("Node is not summary node")

      Expected Results:
      All OLAP classes and interfaces should have strings which are kept in resource bundles.

      Attachments

        Activity

          People

            adobejira Adobe JIRA
            adobejira Adobe JIRA
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: