[FLEX-27291] Redundant code in Scroller: orientation change handler

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: Adobe Flex SDK Previous
• Component/s: Spark: Scroller
• Labels: performance
• Environment: Affected OS(s): All OS Platforms; Language Found: English
• Assignee: Unassigned
• Reporter: Adobe JIRA
• Created: 13/Apr/11 01:18
• Updated: 04/May/13 01:37

Description

Found in version: Hero i6 (prerelease)

orientationChangeHandler seems to be redundant, since the scroll positions depends on scroller/viewport properties (height, contentHeight, etc), not something top and global like device orientation. This brings undesirable dependencies and affects the performance a bit (since it would make double proccessing on orientation change and on component properties change).

Solution: remove everything regarding orientation.

If someone will point on checkScrollPosition() and how orientation change affects stopping throwEffect and snapping — it makes more sense to distinguish between viewport's content resize and scroller resize to achieve that. But not the orientation. The code smells... like _global variables.