[FLEX-27200] SkinnableDataContainer.updateRender sets the data variable unnecessarily causing unnecessary screen updates

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: Adobe Flex SDK 4.5 (Release)
• Component/s: Spark: SkinnableDataContainer
• Environment: Affected OS(s): All OS Platforms; Affected OS(s): All OS Platforms; Language Found: English
• Assignee: Adobe JIRA
• Reporter: Adobe JIRA
• Created: 31/Mar/11 16:15
• Updated: 07/Sep/11 15:20
• Resolved: 07/Sep/11 15:17

Description

I'm working with Flex 4.5.0.20427.

The last conditional in SkinnableDataContainer.updateRenderer is:

// always set the data last
if ((renderer is IDataRenderer) && (renderer !== data))
IDataRenderer(renderer).data = data;

I expect the author intended:

// always set the data last
if ((renderer is IDataRenderer) && (renderer.data !== data))
IDataRenderer(renderer).data = data;

In my use case this results in lots of extra updates to items in a container due to the event sent by the data setter.