[FLEX-26855] Scroller's keyDownHandler and skin_mouseWheelHandler are declared private and they should be protected

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: Adobe Flex SDK 4.1 (Release)
• Component/s: Spark: Scroller
• Environment: Affected OS(s): Windows; Affected OS(s): Windows XP; Language Found: English
• Assignee: Unassigned
• Reporter: Adobe JIRA
• Created: 20/Feb/11 10:29
• Updated: 03/Oct/11 14:44

Description

Scroller's keyDownHandler and skin_mouseWheelHandler are declared private and they should be protected.

Both H and V ScrollBars have the same functions protected and can be extended. And when I do, I have problems cause in some cases the events are handled by the Scroller and I can't extend and override these functions.

Also I have another suggestion for a solution here. Here it is:

At the moment Scroller duplicates the keyDownHandler and skin_mouseWheelHandler functions with the only difference that it checks if the vertical scroller is visible, if it is it uses it's code, if it's not it uses the horizontalScrollBar code.

I think this duplication of functionality is confusing and not expected and when extending it doubles the changes one needs to make. When using the Scroller component knowing it relies on his 2 subcomponents - vertical and horizontal scrollBars I expect that he manages them, and so every event within the Scroller component should be passed to them, not handled by the scroller itself.

So my suggestion here for a fix is instead of duplicating the functionality in both functions i mentioned above, just redispatch the event to the appropriate scrollBar component and let it handle the event. If you do this that would also mean there's no need to declare those 2 functions protected cause everything will be handled by the scrollBars and their functions I can extend at the moment.