[FLEX-19388] Cleanup: WindowedSystemManager has lots of dead code because topLevel is never false

• Type: Task
• Status: Closed
• Priority: Trivial
• Resolution: Later
• Affects Version/s: Adobe Flex SDK 3.1 (Release)
• Component/s: mx: Window
• Environment: Affected OS(s): All OS Platforms; Language Found: English
• Assignee: Adobe JIRA
• Reporter: Adobe JIRA
• Created: 20/May/09 15:21
• Updated: 03/Jun/09 18:44
• Resolved: 03/Jun/09 18:40

Description

WindowedSystemManager has a topLevel property that is always true (it's private, initialized to true, and never set anywhere else). There's a lot of code with if statements checking the value of topLevel, and a good amount of those blocks of code will only run if topLevel is false (which it never will be). I think all of this is vestigal, from when WindowedSystemManager started out by copy & pasting all the SystemManager code in bulk.

We should clean this up – remove all the code that will never run, and remove the topLevel property itself.

(This cruft still exists in Flex 4, btw)