[FINERACT-949] Improve Java API style used for writing integration tests in Fineract

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Auto Closed
• Labels: Cleanup2022 integration-test technical testing
• Assignee: Unassigned
• Reporter: Michael Vorburger
• Created: 08/May/20 17:10
• Updated: 07/Nov/22 18:11
• Resolved: 07/Nov/22 18:11

Description

The current (Java) "style" that integration tests are written in in Fineract is... really ugly!

They are from a bygone era when Java had no generic. All those weird java.util.HashSet, with a lot of java.lang.Object etc. in tests are... so not 21st century style.

I don't really have the answer here, yet - but perhaps others have ideas - how does one write Java (test) code in 2020 which deals with JSON in a nicer way?

Does REST Assured (http://rest-assured.io) meanwhile offer a better way to do this kind of thing?

Could https://github.com/skyscreamer/JSONassert be of use and interest for this purpose?

BTW if using REST Assured better than we are is part of the answer here, then let's first do FINERACT-884.

Issue Links

• Blocked: FINERACT-865 Strengthen/Harden Fineract 1.x to LTS Version by Upgrading Java & Improving Code Coverage of Tests
• relates to: FINERACT-996 Fineract Java Client API library
• requires: FINERACT-884 Upgrade rest-assured to latest version (later than 3.3.0. from Spring Boot BOM), which requires Java 11/9+
• links to: GitHub Pull Request #842