Uploaded image for project: 'Apache Fineract'
  1. Apache Fineract
  2. FINERACT-936

PlatformApiDataValidationException at ClientDataValidator

Details

    • Bug
    • Status: Reopened
    • Major
    • Resolution: Unresolved
    • 1.4.0
    • None
    • None
    • None

    Description

      See FINERACT-932 for general background, and determine if this error log can and should be "fixed", or if this represents a condition that shouldn't be logged as an error (or conclude that this is a totally valid error log that is useful, any why):

      org.apache.fineract.infrastructure.core.exception.PlatformApiDataValidationException
      	at org.apache.fineract.portfolio.client.data.ClientDataValidator.throwExceptionIfValidationWarningsExist(ClientDataValidator.java:584)
      	at org.apache.fineract.portfolio.client.data.ClientDataValidator.validateForCreate(ClientDataValidator.java:231)
      	at org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl.createClient(ClientWritePlatformServiceJpaRepositoryImpl.java:224)
      	at org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl$$FastClassBySpringCGLIB$$71ca1b7f.invoke(<generated>)

      Attachments

        Issue Links

          Activity

            This exception appears valid as this is what is expected of the class. It is properly throwing an exception when a validation error is encountered.

            natashan Natasha Natarajan added a comment - This exception appears valid as this is what is expected of the class. It is properly throwing an exception when a validation error is encountered.
            vorburger Michael Vorburger added a comment - - edited

            > This exception appears valid as this is what is expected of the class. It is properly throwing an exception when a validation error is encountered.

            Nope! As per https://github.com/apache/fineract/#logging-guidelines, quote:

            do NOT include e.g. validation errors for incoming API requests - that is signaled through the API response - and does (should) not be logged as an error.

            We need an integration test which verified that whatever can cause this condition is returning an appropriate response in the REST API - and does not log it.

            natashan do you want to work on this? If not, please un-assign this issue from yourself.

            vorburger Michael Vorburger added a comment - - edited > This exception appears valid as this is what is expected of the class. It is properly throwing an exception when a validation error is encountered. Nope! As per https://github.com/apache/fineract/#logging-guidelines , quote: do NOT include e.g. validation errors for incoming API requests - that is signaled through the API response - and does (should) not be logged as an error. We need an integration test which verified that whatever can cause this condition is returning an appropriate response in the REST API - and does not log it. natashan do you want to work on this? If not, please un-assign this issue from yourself.

            I am removing myself as I have a backlog of issues and in case someone else might be able to resolve sooner than I am able.

            natashan Natasha Natarajan added a comment - I am removing myself as I have a backlog of issues and in case someone else might be able to resolve sooner than I am able.

            People

              Unassigned Unassigned
              vorburger Michael Vorburger
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: