Uploaded image for project: 'Apache Fineract'
  1. Apache Fineract
  2. FINERACT-911

Alternative way(s) to set Git revision on CI systems which do shallow git clone

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Won't Do
    • Affects Version/s: None
    • Fix Version/s: 1.4.0
    • Component/s: None
    • Labels:
      None

      Description

      FINERACT-883 will expose Fineract build's Git revision on /actuator/info HTTP API endpoint.

      But as discussed on https://github.com/apache/fineract/pull/778, the project should still build even if there is no `.git/` directory present. This could happen if someone builds inside a Docker container, or some of things I have in mind for the future (https://github.com/actions/checkout note `-depth` and `-unshallow`, and e.g. https://cloud.google.com/cloud-build/docs/running-builds/create-manage-triggers doing a shallow clone, by default)... let me open new FINERACT-tbd to look into that, after this is merged. (On TravisCI it's fine though, because they do `git clone --depth=50`.)

      The goal of this issue is to look into alternative ways to set the Fineract Release Git revision details. For example, using the GitHub Checkout Action, it may be possible to either specify the right parameter for depth 1. If that is impossible, then perhaps the Git revision could be "passed through" via some... environment variable?

      Let's deal with this after FINERACT-883, and once we see real problems.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                vorburger Michael Vorburger
                Reporter:
                vorburger Michael Vorburger
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: