[FINERACT-891] ClientSavingsIntegrationTest has Dead Code due to if (Calendar.DAY_OF_MONTH >= 22)

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Auto Closed
• Labels: Cleanup2022 beginner
• Assignee: Unassigned
• Reporter: Michael Vorburger
• Created: 13/Apr/20 17:59
• Updated: 07/Nov/22 18:11
• Resolved: 07/Nov/22 18:11

Description

while staring at ClientSavingsIntegrationTest for FINERACT-852, I noticed that in it has x2 Dead Code due to if (Calendar.DAY_OF_MONTH >= 22) ... that will always be false. I'm guessing that has was meant to check ... I'm not sure, presumably the transactionDate? That doesn't really make much sense either, as that's hard-coded to transactionDate.set(Calendar.DAY_OF_MONTH, 22); just 2 lines above.

Someone who better understands what that test does should probably review it.

Issue Links

• relates to: FINERACT-852 ArrayIndexOutOfBoundsException in ClientSavingsIntegrationTest and SchedulerJobsTest