Uploaded image for project: 'Apache Fineract'
  1. Apache Fineract
  2. FINERACT-820

LoanReschedulingWithinCenterTest is flaky and always fails on Sundays

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.4.0
    • None
    • None

    Description

      https://github.com/apache/fineract/pull/678 for FINERACT-726 just failed due to:

      > Task :integrationTest                                                                                                                                                                     
                                                                                                                                                                                                  
      344 tests completed, 2 failed, 14 skipped

      due to:

      1. org.apache.fineract.integrationtests.LoanReschedulingWithinCenterTest

              at org.apache.fineract.integrationtests.common.Utils.performServerPost(Utils.java:156)
              at org.apache.fineract.integrationtests.common.CalendarHelper.createMeetingForGroup(CalendarHelper.java:101)
              at org.apache.fineract.integrationtests.LoanReschedulingWithinCenterTest.createCalendarMeeting(LoanReschedulingWithinCenterTest.java:181)
              at org.apache.fineract.integrationtests.LoanReschedulingWithinCenterTest.testCenterReschedulingLoansWithInterestRecalculationEnabled(LoanReschedulingWithinCenterTest.java:97)
      
      -----------------------------------LOGIN-----------------------------------------
      ------------------------ RETRIEVING ALL GLOBAL CONFIGURATIONS -------------------------
      map : {dateFormat=dd MMMM yyyy, name=Office_PLBT, locale=en, openingDate=01 July 2007, parentId=1}
      map : {firstname=michael_U2MM2, officeId=1, dateFormat=dd MMMM yyyy, joiningDate=20 September 2011, isLoanOfficer=true, locale=en, lastname=Doe_URN3}
      ------------------------CREATING CENTER-------------------------
      ------------------------ RETRIEVING CENTER AT 180-------------------------
      ---------------------------------CREATING A MEETING CALENDAR FOR THE GROUP------------------------------
      /fineract-provider/api/v1/centers/180/calendars?tenantIdentifier=default
      map : {repeatsOnDay=0, dateFormat=dd MMMM yyyy, repeating=true, interval=2, typeId=1, locale=en, title=groups_CollectionMeetingF3FP, startDate=05 January 2020, frequency=2}
      HTTP/1.1 400 Bad Request
      Server: Apache-Coyote/1.1
      X-Notification-Refresh: true
      Access-Control-Allow-Origin: *
      Access-Control-Allow-Methods: GET, POST, PUT, DELETE, OPTIONS
      Cache-Control: no-cache, no-store, max-age=0, must-revalidate
      Pragma: no-cache
      Expires: 0
      Strict-Transport-Security: max-age=31536000 ; includeSubDomains
      X-XSS-Protection: 1; mode=block
      X-Frame-Options: DENY
      X-Content-Type-Options: nosniff
      Content-Type: application/json
      Transfer-Encoding: chunked
      Date: Sun, 05 Jan 2020 17:57:32 GMT
      Connection: close
      
      {
          "developerMessage": "The request was invalid. This typically will happen due to validation errors which are provided.",
          "httpStatusCode": "400",
          "defaultUserMessage": "Validation errors exist.",
          "userMessageGlobalisationCode": "validation.msg.validation.errors.exist",
          "errors": [
              {
                  "developerMessage": "The parameter repeatsOnDay must be between 1 and 7.",
                  "defaultUserMessage": "The parameter repeatsOnDay must be between 1 and 7.",
                  "userMessageGlobalisationCode": "validation.msg.calendar.repeatsOnDay.is.not.within.expected.range",
                  "parameterName": "repeatsOnDay",
                  "value": null,
                  "args": [
                      {
                          "value": 0
                      },
                      {
                          "value": 1
                      },
                      {
                          "value": 7
                      }
                  ]
              }
          ]
      }

      2. testCenterReschedulingMultiTrancheLoansWithInterestRecalculationEnabled

      If The parameter repeatsOnDay must be between 1 and 7. then probably doing repeatsOnDay = today.get(Calendar.DAY_OF_WEEK) - 1; in https://github.com/apache/fineract/blob/develop/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/LoanReschedulingWithinCenterTest.java isn't great?

      
      

      Attachments

        Issue Links

          Activity

            People

              angelboxes Angel Cajas
              vorburger Michael Vorburger
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m